Added new switch to allow inclusion of all class teams #49
Conversation
|
|
| function Get-SDSTeams($logFilePath) { | ||
| $initialSDSGroupUri = "https://graph.microsoft.com/beta/groups?`$filter=groupTypes/any(c:c+eq+'Unified')+and+startswith(mailNickname,'Section_')+and+resourceProvisioningOptions/Any(x:x+eq+'Team')&$groupSelectClause" | ||
| function Get-SDSTeams($IncludeNonSDSGroups, $logFilePath) { | ||
| $initialSDSGroupUri = "https://graph.microsoft.com/beta/groups?`$filter=groupTypes/any(c:c+eq+'Unified')" + $(if(-Not $IncludeNonSDSGroups) {"+and+startswith(mailNickname,'Section_')"}) + "+and+resourceProvisioningOptions/Any(x:x+eq+'Team')&$groupSelectClause" |
There was a problem hiding this comment.
I think this can be made easier to read. Either:
$initialSDSGroupUri = "https://graph.microsoft.com/beta/groups?$groupSelectClause&`$filter=groupTypes/any(c:c+eq+'Unified')+and+resourceProvisioningOptions/Any(x:x+eq+'Team')" + $(if(-Not $IncludeNonSDSGroups) {"+and+startswith(mailNickname,'Section_')"})
OR
$initialSDSGroupUri = "https://graph.microsoft.com/beta/groups?$groupSelectClause&`$filter=groupTypes/any(c:c+eq+'Unified')+and+resourceProvisioningOptions/Any(x:x+eq+'Team')"
if (-Not $IncludeNonSDSGroups) {
$initialSDSGroupUri = "$initialSDSGroupUri+and+startswith(mailNickname,'Section_')"
}
There was a problem hiding this comment.
The pertinent part of this was to eliminate the inline, middle of the string if (-Not $includeNonSdsGroups) and make it a possible suffix, to limit the risk of the $select statement being ignored. Your new version still has the $filter at the start.
| @@ -127,12 +130,19 @@ function PageAll-GraphRequest($initialUrl, $logFilePath) { | |||
|
|
|||
| $groupSelectClause = "`$select=id,mailNickname,emailAddress,displayName,resourceProvisioningOptions" | |||
|
|
|||
| function Check-Team($group) { | |||
| function Check-Team($IncludeNonSDSGroups, $group) { | |||
| if (($group.resourceProvisioningOptions -ne $null) -and $group.resourceProvisioningOptions.Contains("Team") -and $group.mailNickname.StartsWith("Section_")) { | |||
There was a problem hiding this comment.
I think you need to also remove the last filter.
No description provided.